!assets/1eQjyva0NPFrFajInkZDfqQ.png Private or broken link
The page you're looking for is either not available or private!
When developing controllers in ASP.NET Core, there are certain practices that should be avoided to ensure maintainability, performance, and adherence to best practices. Here are 12 things we should avoid in our controllers.
1. Tight coupling
Avoid tightly coupling in controllers with specific dependencies or frameworks. Instead, use dependency injection to inject dependencies into controllers. This promotes loose coupling and makes the code more testable and maintainable.
// Avoid:
[ApiController]
[Route("[controller]")]
public class ProductController : ControllerBase
{
ProductService productService = new ProductService();
// ...
}
// Prefer:
[ApiController]
[Route("[controller]")]
public class ProductController : ControllerBase
{
private readonly ILogger<ProductController> _logger;
private readonly IProductService _productService;
public ProductController(IProductService productService, ILogger<ProductController> logger)
{
_logger = logger;
_productService = productService;
}
// ...
}
Learn more about dependency injection
2. Mixing concerns
Controllers should focus on handling HTTP requests and generating responses. Avoid mixing concerns such as data access, authentication, or authorization directly in the controller. Delegate these responsibilities to separate classes or middleware.
// Avoid:
[HttpPost]
public async Task<IActionResult> CreateProduct(ProductDto productDto)
{
// Authentication and authorization logic here
// ...
// Data access logic here
// ...
return Ok(StatusCodes.Status201Created);
}
// Prefer:
[HttpPost]
[Authorize]
public async Task<IActionResult> CreateProduct(ProductDto productDto)
{
await _productService.CreateAsync(productDto);
return Ok(StatusCodes.Status201Created);
}
| Learn more about the Single-responsibility principle _ | _ Separation of concerns |
3. Lack of exception handling
Controllers should handle exceptions gracefully and return appropriate error responses. Avoid letting exceptions propagate to the client without proper handling. Implement global…